Mcp features ii #771
Merged
Mcp features ii #771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegklimov
reviewed
May 13, 2025
| elements.push(MultimodalElement { | ||
| m_type: mime_type, | ||
| m_content: image_content.data, | ||
| }) |
There was a problem hiding this comment.
Did you see a call actually produce an image?
There was a problem hiding this comment.
Yes, mcp puppeteer screenshot, it works
olegklimov
reviewed
May 13, 2025
| @@ -175,6 +176,9 @@ async fn main() { | |||
| crate::git::checkpoints::init_shadow_repos_if_needed(gcx_clone).await; | |||
| }); | |||
|
|
|||
| // Start or connect to mcp servers | |||
| let _ = running_integrations::load_integrations(gcx.clone(), cmdline.experimental, &["**/mcp_*".to_string()]).await; | |||
|
|
|||
There was a problem hiding this comment.
Right, should help with benchmarks
humbertoyusta
force-pushed
the
mcp-features-ii
branch
from
c5fbe79 to
d40a692
Compare
|
@olegklimov not with the split between mcp sse and mcp stdio (UI is not ready yet, but LSP looks like it is) |
…mand is specified, to match config with claude desktop
humbertoyusta
force-pushed
the
mcp-features-ii
branch
from
5438d76 to
d4f0312
Compare
humbertoyusta
force-pushed
the
mcp-features-ii
branch
from
d4f0312 to
072f0f9
Compare
alashchev17
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.